代码优化

icssman-service/src/main/java/com/diagbot/facade/DisclaimerInformationFacaed.java

@@ -1,14 +1,5 @@
 package com.diagbot.facade;
 
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.stream.Collectors;
-
-import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.stereotype.Component;
-
 import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
 import com.baomidou.mybatisplus.core.conditions.update.UpdateWrapper;
 import com.baomidou.mybatisplus.core.metadata.IPage;
@@ -27,6 +18,14 @@ import com.diagbot.util.UserUtils;
 import com.diagbot.vo.DisclaimerInformationAllVO;
 import com.diagbot.vo.DisclaimerInformationIdVO;
 import com.diagbot.vo.DisclaimerInformationVO;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Component;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
 
 /**
  * @author wangfeng
@@ -113,13 +112,7 @@ public class DisclaimerInformationFacaed extends DisclaimerInformationServiceImp
      */
     public Boolean updateDisclaimerInformation(DisclaimerInformationAllVO disclaimerInformationAllVO) {
         // 1.先判断数据是否存在有效
-        QueryWrapper<DisclaimerInformation> disclaimerInformationFand = new QueryWrapper<>();
-        disclaimerInformationFand.eq("is_deleted", IsDeleteEnum.N.getKey()).eq("id",
-                disclaimerInformationAllVO.getId());
-        int sum = count(disclaimerInformationFand);
-        if (sum == 0 ) {
-            throw new CommonException(CommonErrorCode.NOT_EXISTS, "该数据不存在");
-        }
+        checkExist(disclaimerInformationAllVO.getId());
         // 2.修改版本详情信息
         DisclaimerInformation disclaimerInformation = new DisclaimerInformation();
 
@@ -150,14 +143,8 @@ public class DisclaimerInformationFacaed extends DisclaimerInformationServiceImp
      * @return
      */
     public Boolean cancelDisclaimerInformation(DisclaimerInformationIdVO disclaimerInformationIdVO) {
-    	 // 1.先判断数据是否存在有效
-        QueryWrapper<DisclaimerInformation> disclaimerInformationFand = new QueryWrapper<>();
-        disclaimerInformationFand.eq("is_deleted", IsDeleteEnum.N.getKey()).eq("id",
-        		disclaimerInformationIdVO.getId());
-        int sum = count(disclaimerInformationFand);
-        if (sum == 0 ) {
-            throw new CommonException(CommonErrorCode.NOT_EXISTS, "该数据不存在");
-        }
+        // 1.先判断数据是否存在有效
+        checkExist(disclaimerInformationIdVO.getId());
         UpdateWrapper<DisclaimerInformation> disclaimerInformationNew = new UpdateWrapper<>();
         disclaimerInformationNew.in("id", disclaimerInformationIdVO.getId()).eq("is_deleted", IsDeleteEnum.N.getKey())
                 .set("is_deleted", IsDeleteEnum.Y.getKey()).set("modifier", UserUtils.getCurrentPrincipleID())
@@ -171,14 +158,8 @@ public class DisclaimerInformationFacaed extends DisclaimerInformationServiceImp
      * @return
      */
     public boolean startDisclaimerInformations(DisclaimerInformationIdVO disclaimerInformationIdVO) {
-    	 // 1.先判断数据是否存在有效
-        QueryWrapper<DisclaimerInformation> disclaimerInformationFand = new QueryWrapper<>();
-        disclaimerInformationFand.eq("is_deleted", IsDeleteEnum.N.getKey()).eq("id",
-        		disclaimerInformationIdVO.getId());
-        int sum = count(disclaimerInformationFand);
-        if (sum == 0 ) {
-            throw new CommonException(CommonErrorCode.NOT_EXISTS, "该数据不存在");
-        }
+        // 1.先判断数据是否存在有效
+        checkExist(disclaimerInformationIdVO.getId());
         UpdateWrapper<DisclaimerInformation> disclaimerInformationNew = new UpdateWrapper<>();
         disclaimerInformationNew.in("id", disclaimerInformationIdVO.getId()).eq("is_deleted", IsDeleteEnum.N.getKey())
                 .eq("status", StatusEnum.Disable.getKey()).set("modifier", UserUtils.getCurrentPrincipleID())
@@ -192,14 +173,8 @@ public class DisclaimerInformationFacaed extends DisclaimerInformationServiceImp
      * @return
      */
     public boolean endDisclaimerInformations(DisclaimerInformationIdVO disclaimerInformationIdVO) {
-    	 // 1.先判断数据是否存在有效
-        QueryWrapper<DisclaimerInformation> disclaimerInformationFand = new QueryWrapper<>();
-        disclaimerInformationFand.eq("is_deleted", IsDeleteEnum.N.getKey()).eq("id",
-        		disclaimerInformationIdVO.getId());
-        int sum = count(disclaimerInformationFand);
-        if (sum == 0 ) {
-            throw new CommonException(CommonErrorCode.NOT_EXISTS, "该数据不存在");
-        }
+        // 1.先判断数据是否存在有效
+        checkExist(disclaimerInformationIdVO.getId());
         UpdateWrapper<DisclaimerInformation> disclaimerInformationNew = new UpdateWrapper<>();
         disclaimerInformationNew.in("id", disclaimerInformationIdVO.getId()).eq("is_deleted", IsDeleteEnum.N.getKey())
                 .eq("status", StatusEnum.Enable.getKey()).set("modifier", UserUtils.getCurrentPrincipleID())
@@ -207,4 +182,18 @@ public class DisclaimerInformationFacaed extends DisclaimerInformationServiceImp
         return update(new DisclaimerInformation(), disclaimerInformationNew);
     }
 
+    /**
+     * 判断数据是否存在有效
+     *
+     * @param id
+     */
+    private void checkExist(Long id) {
+        QueryWrapper<DisclaimerInformation> disclaimerInformationFand = new QueryWrapper<>();
+        disclaimerInformationFand.eq("is_deleted", IsDeleteEnum.N.getKey()).eq("id", id);
+        int sum = count(disclaimerInformationFand);
+        if (sum == 0) {
+            throw new CommonException(CommonErrorCode.NOT_EXISTS, "该数据不存在");
+        }
+    }
+
 }