Browse Source

优化代码2.1

wangfeng 6 years ago
parent
commit
48ffa7889b

+ 2 - 2
icss-service/src/main/java/com/diagbot/facade/TemplateInfoFacade.java

@@ -64,8 +64,8 @@ public class TemplateInfoFacade extends TemplateInfoServiceImpl {
         QueryWrapper<TemplateInfo> templateInfoFand = new QueryWrapper<>();
         templateInfoFand.eq("is_deleted", IsDeleteEnum.N.getKey())
                 .eq("id", templateInfoRevampVO.getId());
-        TemplateInfo data = getOne(templateInfoFand);
-        if (data == null) {
+        int sum = count(templateInfoFand);
+        if (sum == 0) {
             throw new CommonException(CommonErrorCode.NOT_EXISTS, "该模板不存在");
         }
         //2.再判断该医生下模板名是否重复重在

+ 2 - 8
icssman-service/src/main/java/com/diagbot/facade/VersionInfoFacade.java

@@ -181,12 +181,6 @@ public class VersionInfoFacade extends VersionInfoServiceImpl {
     public boolean updateVersionInfoAll(VersionInfoAllVO versionInfoVO) {
         // 1.先判断数据是否存在有效
     	checkExist(versionInfoVO.getId());
-/*        QueryWrapper<VersionInfo> VersionInfoFand = new QueryWrapper<>();
-        VersionInfoFand.eq("is_deleted", IsDeleteEnum.N.getKey()).eq("id", versionInfoVO.getId());
-        VersionInfo data = getOne(VersionInfoFand);
-        if (data == null) {
-            throw new CommonException(CommonErrorCode.NOT_EXISTS, "该数据不存在");
-        }*/
         // 2.判断该版本号是否存在名字相同的数据
         QueryWrapper<VersionInfo> templateInfoFand = new QueryWrapper<>();
         templateInfoFand.eq("name", versionInfoVO.getName()).eq("is_deleted", IsDeleteEnum.N.getKey());
@@ -244,8 +238,8 @@ public class VersionInfoFacade extends VersionInfoServiceImpl {
     	 // 1.先判断数据是否存在有效
         QueryWrapper<VersionInfo> VersionInfoFand = new QueryWrapper<>();
         VersionInfoFand.eq("is_deleted", IsDeleteEnum.N.getKey()).eq("id", id);
-        VersionInfo data = getOne(VersionInfoFand);
-        if (data == null) {
+        int sum = count(VersionInfoFand);
+        if (sum == 0) {
             throw new CommonException(CommonErrorCode.NOT_EXISTS, "该数据不存在");
         }
     }