Browse Source

接口优化

zhoutg 6 years ago
parent
commit
53d5d9bd03

+ 2 - 1
icss-service/src/main/java/com/diagbot/facade/DisScaleFacade.java

@@ -6,6 +6,7 @@ import com.diagbot.dto.RespDTO;
 import com.diagbot.exception.CommonErrorCode;
 import com.diagbot.exception.CommonException;
 import com.diagbot.service.impl.DisScaleServiceImpl;
+import com.diagbot.util.RespDTOUtil;
 import com.diagbot.vo.DisScaleVO;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
@@ -31,7 +32,7 @@ public class DisScaleFacade extends DisScaleServiceImpl {
      */
     public List<DisScaleDTO> getDisScaleFac(DisScaleVO disScaleVO) {
         RespDTO<List<DisScaleDTO>> res = aiptServiceClient.getList(disScaleVO);
-        if (res == null || !CommonErrorCode.OK.getCode().equals(res.code)) {
+        if (RespDTOUtil.respIsNG(res)) {
             throw new CommonException(CommonErrorCode.RPC_ERROR, "远程调用诊断量表列表失败");
         }
         return res.data;

+ 2 - 1
icss-service/src/main/java/com/diagbot/facade/DisTypeFacade.java

@@ -11,6 +11,7 @@ import com.diagbot.enums.QuestionTypeEnum;
 import com.diagbot.exception.CommonErrorCode;
 import com.diagbot.exception.CommonException;
 import com.diagbot.service.impl.DisTypeServiceImpl;
+import com.diagbot.util.RespDTOUtil;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
@@ -33,7 +34,7 @@ public class DisTypeFacade extends DisTypeServiceImpl {
      */
     public DisTypeDTO getDisTypeFac() {
         RespDTO<DisTypeDTO> res =  aiptServiceClient.getDisType();
-        if (res == null || !CommonErrorCode.OK.getCode().equals(res.code)) {
+        if (RespDTOUtil.respIsNG(res)) {
             throw new CommonException(CommonErrorCode.RPC_ERROR, "远程调用诊断类型失败");
         }
         return res.data;

+ 2 - 1
icss-service/src/main/java/com/diagbot/facade/ScaleContentFacade.java

@@ -9,6 +9,7 @@ import com.diagbot.enums.ScaleTypeEnum;
 import com.diagbot.exception.CommonErrorCode;
 import com.diagbot.exception.CommonException;
 import com.diagbot.service.impl.ScaleContentServiceImpl;
+import com.diagbot.util.RespDTOUtil;
 import com.diagbot.vo.PushVO;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
@@ -36,7 +37,7 @@ public class ScaleContentFacade extends ScaleContentServiceImpl {
     public List<ScaleContent> getContent(PushVO pushVO) {
         SearchData searchData = pushFacade.assembleData(pushVO);
         RespDTO<List<ScaleContent>> res = aiptServiceClient.getScale(searchData);
-        if (res == null || !CommonErrorCode.OK.getCode().equals(res.code)) {
+        if (RespDTOUtil.respIsNG(res)) {
             throw new CommonException(CommonErrorCode.RPC_ERROR, "远程调用量表内容失败");
         }
         return res.data;