优化代码

icssman-service/src/main/java/com/diagbot/facade/DeptVitalFacade.java

@@ -160,12 +160,7 @@ public class DeptVitalFacade extends DeptVitalServiceImpl {
                 .map(deptVitals -> deptVitals.getVitalId())
                 .collect(Collectors.toList());
         List<QuestionInfo> vitalList = Lists.newArrayList(questionFacade.listByIds(vitalIds));
-        List<QuestionShortDTO> vitals = Lists.newArrayList();
-        for (QuestionInfo questionInfo : vitalList) {
-            QuestionShortDTO questionShortDTO = new QuestionShortDTO();
-            BeanUtil.copyProperties(questionInfo, questionShortDTO);
-            vitals.add(questionShortDTO);
-        }
+        List<QuestionShortDTO> vitals = BeanUtil.listCopyTo(vitalList, QuestionShortDTO.class);
         deptVitalDTO.setVitals(vitals);
 
         //未关联查体
@@ -213,16 +208,11 @@ public class DeptVitalFacade extends DeptVitalServiceImpl {
      * @return
      */
     public List<DeptShortDTO> getDeptShortList(List<Long> deptIds) {
-        List<DeptShortDTO> deptShortDTOList = Lists.newLinkedList();
         QueryWrapper<DeptInfo> deptInfoQueryWrapper = new QueryWrapper<>();
         deptInfoQueryWrapper.eq("is_deleted", IsDeleteEnum.N.getKey()).
                 notIn("id", deptIds);
         List<DeptInfo> deptInfoList = deptInfoFacade.list(deptInfoQueryWrapper);
-        for (DeptInfo deptInfo : deptInfoList) {
-            DeptShortDTO deptShortDTO = new DeptShortDTO();
-            BeanUtil.copyProperties(deptInfo, deptShortDTO);
-            deptShortDTOList.add(deptShortDTO);
-        }
+        List<DeptShortDTO> deptShortDTOList = BeanUtil.listCopyTo(deptInfoList, DeptShortDTO.class);
         return deptShortDTOList;
     }
 

icssman-service/src/main/java/com/diagbot/facade/DisclaimerInformationFacaed.java

@@ -14,6 +14,7 @@ import com.diagbot.exception.CommonErrorCode;
 import com.diagbot.exception.CommonException;
 import com.diagbot.service.impl.DisclaimerInformationServiceImpl;
 import com.diagbot.util.DateUtil;
+import com.diagbot.util.ListUtil;
 import com.diagbot.util.UserUtils;
 import com.diagbot.vo.DisclaimerInformationAllVO;
 import com.diagbot.vo.DisclaimerInformationIdVO;
@@ -56,7 +57,7 @@ public class DisclaimerInformationFacaed extends DisclaimerInformationServiceImp
         modifierid = data.stream().map(ac -> ac.getModifier()).collect(Collectors.toList());
 
         Map<String, String> userNames = new HashMap<>();
-        if (modifierid.size() > 0) {
+        if (ListUtil.isNotEmpty(modifierid)) {
             RespDTO<Map<String, String>> userNamesDTO = userServiceClient.getUserInfoByIds(modifierid);
             if (userNamesDTO == null || !CommonErrorCode.OK.getCode().equals(userNamesDTO.code)) {
                 throw new CommonException(CommonErrorCode.SERVER_IS_ERROR,