代码优化

icssman-service/src/main/java/com/diagbot/facade/IndexConfigFacade.java

@@ -55,10 +55,10 @@ public class IndexConfigFacade extends IndexConfigServiceImpl {
 	public IPage<IndexConfigDTO> queryIndexConfigPage(IndexConfigDiseaseNameVO indexConfigDiseaseNameVO) {
 		IPage<IndexConfigDTO> datas = this.queryIndexConfigPageAlls(indexConfigDiseaseNameVO);
 		List<IndexConfigDTO> data = datas.getRecords();
-		List<String> modifierid = new ArrayList<>();
-		modifierid = data.stream().map(ac -> ac.getModifier()).distinct().collect(Collectors.toList());
+		List<String> modifierid
+				= data.stream().map(ac -> ac.getModifier()).collect(Collectors.toList());
 		Map<String, String> userNames = new HashMap<>();
-		if (modifierid.size() > 0) {
+		if (ListUtil.isNotEmpty(modifierid)) {
 			RespDTO<Map<String, String>> userNamesDTO = userServiceClient.getUserInfoByIds(modifierid);
 			if (RespDTOUtil.respIsNG(userNamesDTO)) {
 				throw new CommonException(CommonErrorCode.SERVER_IS_ERROR, "获取所有用户信息失败");

user-service/src/main/java/com/diagbot/facade/UserFacade.java

@@ -80,6 +80,7 @@ import java.util.Date;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.stream.Collectors;
 
 /**
  * @Description: 用户业务层
@@ -1439,17 +1440,15 @@ public class UserFacade extends UserServiceImpl {
      * @return 用户名信息列表
      */
     public Map<String, String> getUserInfoByIds(List<String> ids) {
-        List<Long> longList = new ArrayList<>();
-        for (String id : ids){
-            if(!longList.contains(id)){
-                longList.add(Long.valueOf(id));
-            }
-        }
-        List<User> userList = this.getByIds(longList);
+        List<Long> longList
+                = ids.stream().map(r->Long.valueOf(r)).distinct().collect(Collectors.toList());
+
         Map<String, String> map = new HashMap<>();
-        if (ListUtil.isNotEmpty(userList)){
-            for (User user: userList){
-                map.put(user.getId().toString(), user.getLinkman());
+        if (ListUtil.isNotEmpty(longList)){
+            List<User> userList = this.getByIds(longList);
+            if (ListUtil.isNotEmpty(userList)){
+                map = userList.stream()
+                        .collect(Collectors.toMap(k->k.getId().toString(), v->v.getLinkman()));
             }
         }
         return map;