代码逻辑优化

knowledgeman-service/src/main/java/com/diagbot/facade/VersionDetailFacade.java

@@ -160,8 +160,10 @@ public class VersionDetailFacade extends VersionDetailServiceImpl {
      */
     public boolean updateVersionDetail(VersionDetailVO versionDetailVO) {
         // 1.先判断数据是否存在有效
-        checkExistMain(versionDetailVO.getDetailId());
-        // 2.修改版本详情信息
+        VersionDetail versionDetailres = checkExist(versionDetailVO.getDetailId());
+        //验证主表是否是可修改状态
+        checkExistMain(versionDetailres.getVersionId());
+        // 3.修改版本详情信息
         VersionDetail versionDetail = new VersionDetail();
 
         versionDetail.setGmtModified(DateUtil.now());// 修改时间
@@ -234,14 +236,15 @@ public class VersionDetailFacade extends VersionDetailServiceImpl {
      *
      * @param id
      */
-    private void checkExist(Long id) {
+    private VersionDetail checkExist(Long id) {
         // 1.先判断数据是否存在有效
         QueryWrapper<VersionDetail> VersionInfoFand = new QueryWrapper<>();
         VersionInfoFand.eq("is_deleted", IsDeleteEnum.N.getKey()).eq("id", id);
-        int sum = count(VersionInfoFand);
-        if (sum == 0) {
+        VersionDetail versionDetail = getOne(VersionInfoFand);
+        if (null == versionDetail) {
             throw new CommonException(CommonErrorCode.NOT_EXISTS, "该数据不存在");
         }
+        return versionDetail;
     }
 
 

knowledgeman-service/src/main/java/com/diagbot/vo/VersionDetailVO.java

@@ -14,7 +14,6 @@ import lombok.Setter;
 @Getter
 @Setter
 public class VersionDetailVO {
-
 	   /**
      * 版本主表id
      */